Fix regex non-multiline EOL/$ matching strings ending with a new-line #9715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9715 +/- ##
===============================================
Coverage ? 10.60%
===============================================
Files ? 118
Lines ? 20082
Branches ? 0
===============================================
Hits ? 2130
Misses ? 17952
Partials ? 0 Continue to review full report at Codecov.
|
cwharris
approved these changes
Nov 17, 2021
vuule
approved these changes
Nov 17, 2021
vuule
added
4 - Needs cuDF (Python) Reviewer
and removed
3 - Ready for Review
skirui-source
approved these changes
Nov 18, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9620
Fixes an edge case described in https://docs.python.org/3/library/re.html#re.MULTILINE
where the '$' EOL regex pattern character (without
MULTILINEset) should match at the very end of a string and also just before the end of the string if the end of that string contains a new-line.